Metaweather alternative#134
Merged
theprash merged 3 commits intoCompositionalIT:masterfrom Jul 1, 2022
Merged
Conversation
Closed
sonicbhoc
suggested changes
Jun 24, 2022
sonicbhoc
left a comment
sonicbhoc
left a comment
There was a problem hiding this comment.
Does not build. emptyWeather type must be updated to use Temperature instead of AverageTemperature.
Contributor
|
@nickgravgaard Thanks very much for making this change. 🙏🏾 I'll see if I can get it ported into the solution branch today. However, since master isn't even building right now, I'll merge this now, even though the solution will be completely out of sync. Generally, I think it's easier to make these changes in the solution branch first (because it's easier to test) and them port them to master later so you might want to try that for any future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metaweather.com is down. This PR changes the code to use open-meteo.com's API and display open source weather icons instead.