Skip to content

Adding support for static website for Storage Account (Post-deploy task)#282

Merged
isaacabraham merged 2 commits intoCompositionalIT:masterfrom
Dzoukr:master
Jul 14, 2020
Merged

Adding support for static website for Storage Account (Post-deploy task)#282
isaacabraham merged 2 commits intoCompositionalIT:masterfrom
Dzoukr:master

Conversation

@Dzoukr
Copy link
Copy Markdown
Contributor

@Dzoukr Dzoukr commented Jul 13, 2020

At Farmer CE:

let store = storageAccount {
    name "romanstaticweb"
    static_website "index.html" "error.html"
}

on Azure:

image

Also added docs + configuration member for getting primary endpoint

store.WebsitePrimaryEndpoint

@Dzoukr
Copy link
Copy Markdown
Contributor Author

Dzoukr commented Jul 13, 2020

Oh, it also probably closes #180 if approved 😉

@Dzoukr
Copy link
Copy Markdown
Contributor Author

Dzoukr commented Jul 14, 2020

Hold on, I got even better idea. Will push soon.

@Dzoukr
Copy link
Copy Markdown
Contributor Author

Dzoukr commented Jul 14, 2020

Ha, now with batch upload to $web folder!

let store = storageAccount {
    name "romanstaticweb"
    static_website_with_content "index.html" "error.html" @"c:\temp\web\"
}

image

and it works 😄

image

@isaacabraham isaacabraham merged commit 1197b9f into CompositionalIT:master Jul 14, 2020
github-actions bot pushed a commit that referenced this pull request Jul 14, 2020
Adding support for static website for Storage Account (Post-deploy task) 1197b9f
@isaacabraham
Copy link
Copy Markdown
Member

Excellentatious. I'll do a quick review - might change the member naming or something - but this is great and will go in the next release. Thanks!

@Dzoukr
Copy link
Copy Markdown
Contributor Author

Dzoukr commented Jul 14, 2020

Please do! 🙏 Me and naming stuff - it's not working together 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants