`estimate_shifts` validation

[j-c-c]

The current testing for the estimate_shifts() method compares the output of the method with a hardcoded result loaded from file. After some inspection, it appears that the estimated shifts do not correspond to the ground truth shifts of the Simulation source, ie. sim.offsets. I'll post the output below.

An effort is being made to replace this entire suite of hardcoded tests in PR #994, but a circle-back will be necessary to address this particular test/method.

[j-c-c]

Here are the outputs of the estimated shifts and source offsets from the testing environment.

estimated shifts:

(Pdb) self.est_shifts.T
array([[ 2.13632431e+00,  1.04869146e+00],
       [ 1.82686807e+00, -1.52490244e+00],
       [-1.78925461e+00,  9.39789010e-01],
       [ 2.87493734e-01, -1.03621250e+00],
       [ 3.19383011e+00,  1.32454925e+00],
       [ 2.48225643e+00, -2.16801263e-01],
       [ 1.11712668e-01,  2.17084648e+00],
       [-6.78706056e-01,  6.62387181e-01],
       [ 3.73095724e-01,  9.88873041e-01],
       [ 2.52409173e+00,  1.20417647e+00],
       [-1.93490078e+00,  4.79471143e-01],
       [ 1.91097384e+00,  3.49423392e-01],
       [ 6.40253115e-01,  8.26877579e-01],
       [-7.53133142e-01,  7.47413058e-01],
       [-5.67313654e-01, -9.00104793e-02],
       [-9.62535974e-01, -8.94735909e-02],
       [-1.13759664e+00, -3.76027025e-01],
       [-2.72650353e-01, -1.25664920e+00],
       [-3.46507831e-01, -2.44901247e-01],
       [-1.31423202e+00,  7.52492170e-01],
       [-1.03166222e+00, -7.09005022e-01],
       [ 5.34458489e-01,  4.68045002e-01],
       [ 3.11357095e-01, -2.84637713e-01],
       [-7.83645108e-01, -5.54874781e-01],
       [-1.21808383e+00,  9.28913468e-01],
       [-5.50305953e-01,  1.25555693e+00],
       [-4.64131328e-01,  2.07706698e-01],
       [-1.14919516e-03, -1.18390132e-01],
       [ 4.90484265e-01, -1.74194729e-01],
       [ 4.35214069e-02, -2.51543309e-01],
       [-1.49805849e-01,  2.33287614e-01],
       [-3.29163303e-01, -1.38684372e-01],
       [-3.78877164e-01, -4.67212464e-01],
       [ 2.38869857e-01, -4.55976233e-01],
       [ 5.35638976e-01, -8.20671945e-02],
       [ 7.58857810e-02, -3.31212941e-01],
       [ 2.44609302e-01, -1.61283857e-01],
       [-2.28408805e-01, -6.96008038e-02],
       [ 3.92183704e-01,  5.61117877e-01],
       [ 3.70728232e-01, -1.12158997e-01],
       [-2.54901439e-01,  1.01718070e-01],
       [-5.87187474e-02, -3.55877321e-01],
       [ 5.68281204e-01, -3.93489733e-01],
       [-1.34904545e+00, -1.72797138e-03],
       [ 3.72207767e-01,  4.62163574e-01],
       [ 1.11840868e+00,  1.56954383e+00],
       [-8.11791713e-01, -4.98273117e-02],
       [ 1.61944124e+00, -8.30394257e-01],
       [ 1.12514263e-01, -1.02080601e+00],
       [ 4.72319342e-01,  8.54715781e-01],
       [ 7.93831620e-02,  9.84116867e-01],
       [ 2.46288453e-01,  4.33512514e-01],
       [-4.19239636e-01,  1.40749210e+00],
       [-7.70522447e-01,  5.98709491e-01],
       [-8.62733354e-01, -5.62325938e-01],
       [ 1.40233436e+00,  6.04853594e-02],
       [-1.36275439e+00,  1.30947634e-01],
       [-1.77830608e+00,  1.38993144e+00],
       [-1.36802931e+00, -1.03862216e+00],
       [ 6.61940886e-01,  1.68266926e+00],
       [-1.84234203e+00,  7.73543927e-01],
       [-1.21579665e+00,  2.19745739e+00],
       [-1.29765076e+00, -1.05249349e+00],
       [ 1.56658037e+00,  1.31362962e+00]])

source offsets:

(Pdb) self.sim.offsets
array([[ 1.7908773 ,  2.6305583 ],
       [-2.2815015 ,  2.7236807 ],
       [ 0.6762168 , -2.5913887 ],
       [-1.1746173 ,  0.23557267],
       [ 3.4449189 ,  3.62094   ],
       [-2.0086327 ,  3.7791557 ],
       [ 3.4374318 , -0.07333206],
       [ 1.685247  , -2.1437657 ],
       [-0.39477947,  2.753892  ],
       [ 1.6282082 ,  3.4896522 ],
       [ 0.8017325 , -3.6055527 ],
       [ 2.0654125 ,  3.0124183 ],
       [ 0.9283296 ,  1.3981034 ],
       [ 1.3060658 , -0.5470387 ],
       [ 0.80030495, -1.8989724 ],
       [ 1.0837407 , -3.7090275 ],
       [-1.1840138 , -3.366334  ],
       [-2.5961385 ,  1.8572466 ],
       [ 1.0191685 , -0.95165026],
       [ 3.294021  , -3.6382527 ],
       [-0.30830696, -0.6027805 ],
       [ 1.4483235 ,  1.6491948 ],
       [-1.7789599 , -0.05131934],
       [-0.2736417 ,  0.7507705 ],
       [ 1.1030602 ,  1.378625  ],
       [-1.1893816 ,  0.9337351 ],
       [ 0.79824215, -1.9675609 ],
       [-2.3600245 , -0.00820145],
       [ 3.495445  , -0.82282126],
       [ 0.43077683, -1.5187646 ],
       [ 1.3569648 , -1.317083  ],
       [ 0.02986534,  1.0434939 ],
       [ 2.462692  ,  3.485044  ],
       [ 0.23725888, -2.1730404 ],
       [-2.0789323 , -1.3020929 ],
       [ 1.9948202 , -1.3221495 ],
       [ 1.7875947 , -1.3900172 ],
       [ 2.9406574 , -0.7707286 ],
       [-1.7076913 , -1.3421658 ],
       [ 0.5902179 , -0.13401006],
       [-0.761688  ,  1.9148898 ],
       [ 0.43075806,  0.24992615],
       [ 2.7728794 , -1.1311638 ],
       [ 1.3946496 ,  1.3725433 ],
       [-0.6086201 ,  0.34166184],
       [-2.867045  , -3.215406  ],
       [ 0.1545497 ,  1.5387675 ],
       [ 3.01269   , -2.2536693 ],
       [ 0.34676018, -0.15360343],
       [-4.5205517 , -0.84065753],
       [-1.9710567 ,  1.6427562 ],
       [-0.98481846,  0.1431661 ],
       [-1.9430076 ,  0.5169609 ],
       [-1.2684237 ,  0.7927137 ],
       [ 0.98725015,  1.3373688 ],
       [-0.24858624, -2.7596354 ],
       [-1.4844403 ,  2.723193  ],
       [-2.052575  ,  1.8755267 ],
       [ 0.19251736,  5.327233  ],
       [-2.8349023 , -0.28836453],
       [-2.4890547 ,  3.5463002 ],
       [-5.2039804 ,  1.510233  ],
       [ 1.8102711 ,  2.2404842 ],
       [-2.7516766 , -0.5078195 ]], dtype=float32)

[garrettwrong]

Closed, completed.