Refactor PolarBasis2D ~~> PolarFT

[j-c-c]

This PR consists of

• Refactoring PolarBasis2D
  • Use only half of the polar Fourier rays everywhere
  • Change to PolarFT
  • Replace hardcoded tests with logical based tests
• Refactor commonline_base and commonline_sync code to work with refactored pft
  • Use rays from [0, n_theta / 2) instead of [n_theta / 2, n_theta)
  • Ensure all methods are following the new pf convention
  • Replace hardcoded tests with parametrized logical based tests

Note, this PR is to address some issues encountered in a downstream branch for the port of the common-lines method using SDP. It was found that our convention for building the common-lines matrix was causing the SDP method to fail.

[codecov]

Codecov Report

Merging #994 (507c337) into develop (5d6f66b) will increase coverage by 0.02%.
The diff coverage is 98.78%.

@@             Coverage Diff             @@
##           develop     #994      +/-   ##
===========================================
+ Coverage    88.79%   88.82%   +0.02%     
===========================================
  Files          127      127              
  Lines        11321    11359      +38     
===========================================
+ Hits         10053    10090      +37     
- Misses        1268     1269       +1     

Files Changed	Coverage Δ
src/aspire/basis/__init__.py	100.00% <ø> (ø)
src/aspire/utils/__init__.py	100.00% <ø> (ø)
src/aspire/utils/rotation.py	97.66% <95.45%> (-0.42%)	⬇️
src/aspire/abinitio/commonline_base.py	94.87% <100.00%> (ø)
src/aspire/operators/__init__.py	100.00% <100.00%> (ø)
src/aspire/operators/polar_ft.py	100.00% <100.00%> (ø)
src/aspire/utils/coor_trans.py	92.71% <100.00%> (+1.11%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[garrettwrong]

Is this guy ready for review? It looks like it was auto triggered, but if your are still working on it I won't put on my todo list quite yet. Thanks

[j-c-c]

Is this guy ready for review? It looks like it was auto triggered, but if your are still working on it I won't put on my todo list quite yet. Thanks

Not quite ready. I mistakenly created this as PR instead of a draft. I reverted to a draft, but it looks like you guys will still get pinged about it.

[j-c-c]

Hey @garrettwrong, this is ready for an initial review. I'm still working on fixing up the estimate_shifts method. I might be able to squeeze it into this PR, but wanted to get an initial review since I'll be out for a few days.

[garrettwrong]

Hey, this is great. Thank you for taking the time to clean this up and verify the implementation.

Mostly quick small stuff. There is the one mode testing issue, but I took a look at it and hope the suggestion is helpful.

[j-c-c]

Oops, sorry @garrettwrong. Left a breakpoint() in there. Should be all good now.

[garrettwrong]

Still a couple stragglers, but otherwise looking good. Thanks.

[garrettwrong]

🚀

[j-c-c]

@janden, this is ready for you to take a look whenever you get a chance. Tagging you here since I mistakenly opened this as a PR instead of a draft and you might have not gotten a review request when I marked as "Ready for Review".

[janden]

Looks good! Just a few things.