FRC and FSC cutoff=None option
#1060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-c-c
reviewed
Dec 4, 2023
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good. Just one question.
Comment on lines
+256
to
+257
| if cutoff is None: | ||
| cutoff = 1 |
Collaborator
There was a problem hiding this comment.
This causes a divide by zero RuntimeWarning when computing the resolution below. I'm sure that's nothing new, but this is the default mode now. Do we want to prevent the warning in this case?
Collaborator
Author
|
Oops, accidently typo'd a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #940 by adding
cutoff=Noneas a defaulted arg. ThisNonesetting does not plot horizontal and vertical lines.Also Closes #1059 , tiny tox/flake CIT update.