Skip to content

Cutoff none #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2023
Merged

Cutoff none #1061

merged 4 commits into from
Dec 6, 2023

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Dec 4, 2023

Replacing #1060 , Github will not allow me to reopen the old PR after deleting the branch.

@garrettwrong garrettwrong added enhancement New feature or request good first issue Good for newcomers cleanup labels Dec 4, 2023
@garrettwrong garrettwrong requested a review from j-c-c December 4, 2023 20:42
@garrettwrong garrettwrong self-assigned this Dec 4, 2023
@garrettwrong garrettwrong marked this pull request as ready for review December 4, 2023 20:44
@garrettwrong garrettwrong requested a review from janden as a code owner December 4, 2023 20:44
j-c-c
j-c-c approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (113590f) 89.14% compared to head (64306d8) 89.15%.
Report is 9 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1061   +/-   ##
========================================
  Coverage    89.14%   89.15%           
========================================
  Files          126      126           
  Lines        11948    11957    +9     
========================================
+ Hits         10651    10660    +9     
  Misses        1297     1297

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Dec 6, 2023

Updating, will merge after CI clears. Minor issue and includes CI bug fix.

@garrettwrong garrettwrong merged commit 257b102 into develop Dec 6, 2023
@garrettwrong garrettwrong deleted the cutoff_none branch December 6, 2023 21:53
@garrettwrong garrettwrong mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

cleanup enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c