Skip to content

SymmetryGroup Pass-through for Volume Transformations #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 21, 2024
Merged

SymmetryGroup Pass-through for Volume Transformations #1084

merged 24 commits into from
Mar 21, 2024

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Feb 8, 2024 •
edited
Loading

Checks whether operations on symmetric volumes should retain symmetry group. If not, the symmetry group is downgraded to C1 and warning is emitted.

Will close #1081.

@j-c-c j-c-c added the bug Something isn't working label Feb 8, 2024
@j-c-c j-c-c self-assigned this Feb 8, 2024
@codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (554601b) to head (b582842).
Report is 24 commits behind head on develop.

❗ Current head b582842 differs from pull request most recent head 96c3742. Consider uploading reports for the commit 96c3742 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1084      +/-   ##
===========================================
+ Coverage    88.82%   88.86%   +0.03%     
===========================================
  Files          126      126              
  Lines        12031    12062      +31     
===========================================
+ Hits         10687    10719      +32     
+ Misses        1344     1343       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-c-c j-c-c requested a review from garrettwrong February 16, 2024 15:12
garrettwrong
garrettwrong requested changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. Couple things to try that might tidy this up. Not sure if end result will be nicer yet, but probably worth trying at this stage.

@j-c-c j-c-c requested a review from garrettwrong February 16, 2024 17:28
garrettwrong
garrettwrong requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks for updating, looked over the tests this time. Pretty close! Let me know if you have any questions. Thanks

@j-c-c j-c-c requested a review from garrettwrong February 26, 2024 14:11
garrettwrong
garrettwrong previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think you covered all the remarks from the first pass, thanks!

@j-c-c j-c-c marked this pull request as ready for review February 29, 2024 16:15
@j-c-c j-c-c requested a review from janden as a code owner February 29, 2024 16:15
janden
janden requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a few things.

@j-c-c j-c-c requested a review from janden March 7, 2024 18:39
@j-c-c j-c-c force-pushed the vol_sym_group branch 2 times, most recently from 9ea23f5 to fb62429 Compare March 13, 2024 17:30
janden
janden approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that this was ready. Here you go!

@j-c-c
Copy link
Collaborator Author

j-c-c commented Mar 20, 2024

Sorry I missed that this was ready. Here you go!

Thanks!

j-c-c added 19 commits March 20, 2024 15:30
@j-c-c j-c-c merged commit dc9ceba into develop Mar 21, 2024
@j-c-c j-c-c mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@garrettwrong garrettwrong garrettwrong left review comments

Assignees

@j-c-c j-c-c

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-c-c @janden @garrettwrong