update cufinufft #1086
Closed
update cufinufft #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1086 +/- ##
===========================================
+ Coverage 88.82% 88.84% +0.02%
===========================================
Files 126 126
Lines 12028 12025 -3
===========================================
Hits 10684 10684
+ Misses 1344 1341 -3 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Hrrm, it appears I was still using the old install. Not having success with actually using v2.2.0 yet. Will continue looking into that. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cufinufft to 2.2.0.
Reverts one of the outstanding workarounds.
WIP. While this appears to work, I still need to review what actually changed between versions. Also should have some additional manual testing.