OrientedSource Lazy Evaluation #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
garrettwrong
requested changes
Mar 4, 2024
Collaborator
garrettwrong
left a comment
garrettwrong
left a comment
There was a problem hiding this comment.
Very minor change. Thanks for putting this together!
| self.pf = self.pf[:, :, 1:] | ||
| pf = pf[:, :, 1:] | ||
|
|
||
| return pf |
Collaborator
There was a problem hiding this comment.
Since you are using the class for the self.src.images data, might as well just have this function assign to self._pf, and update L84.
Collaborator
Author
There was a problem hiding this comment.
Ah yeah, good point. Done. Thanks!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate polar Fourier transform outside of init to enforce lazy eval for OrientedSource's.
Closes #1099