Skip to content

SymmetryGroup Parsing #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 11, 2024
Merged

SymmetryGroup Parsing #1106

merged 7 commits into from
Apr 11, 2024

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Mar 21, 2024

This PR adds some extra parsing logic to SymmetryGroup.from_string() to handle being passed a SymmetryGroup instance or None.

Closes #1083

@j-c-c j-c-c added the cleanup label Mar 21, 2024
@j-c-c j-c-c self-assigned this Mar 21, 2024
@j-c-c j-c-c linked an issue Mar 21, 2024 that may be closed by this pull request
SymmetryGroup Parser #1083
Closed
@j-c-c j-c-c requested a review from garrettwrong April 8, 2024 18:56
garrettwrong
garrettwrong approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this cleaned up a few things, nice. One question, but you can let me know if it is actually going to come up in a way that matters.

@j-c-c j-c-c marked this pull request as ready for review April 9, 2024 18:01
@j-c-c j-c-c requested a review from janden as a code owner April 9, 2024 18:01
janden
janden approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@j-c-c j-c-c merged commit 1ecd61f into develop Apr 11, 2024
@j-c-c j-c-c deleted the sym_parser branch April 11, 2024 17:00
@j-c-c j-c-c mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettwrong garrettwrong garrettwrong approved these changes

@janden janden janden approved these changes

Assignees

@j-c-c j-c-c

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SymmetryGroup Parser

4 participants

@j-c-c @janden @garrettwrong