Hack24 #1140
Hack24 #1140
Conversation
garrettwrong
added
bug
|
Noting this is for the next release, tentatively v0.13.0. |
garrettwrong
force-pushed
the
hack24
branch
2 times, most recently
from
82e843b to
2537de6
Compare
garrettwrong
left a comment
garrettwrong
left a comment
There was a problem hiding this comment.
self review punch list.
garrettwrong
force-pushed
the
hack24
branch
2 times, most recently
from
81761b5 to
aa135c9
Compare
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
This looks great. Just a couple things.
src/aspire/basis/fle_2d.py
Outdated
| _z = nufft(im, self.grid_xy, epsilon=self.epsilon) * self.h**2 | ||
| _z = _z.reshape(num_img, self.num_radial_nodes, self.num_angular_nodes // 2) | ||
| z[:, :, : self.num_angular_nodes // 2] = _z | ||
| z[:, :, self.num_angular_nodes // 2 :] = np.conj(_z) |
There was a problem hiding this comment.
yeah, that should be better, thanks for catching.
There was a problem hiding this comment.
actually i found a few things right in that area I must have missed. sorry about about. You'll see them in the re-review.
[skip ci]
|
A few changes and rebased with latest (resolves that CI patch conflict I had in here). LMK if you see anything else, thanks! |
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good. Just one other suggestion that you can take or leave.
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Looks great! Just a few things.
Closes #1138 , see issue for more detailed list of work.