Rmsh #1173
Merged
Rmsh #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
cleanup
dependencies
Collaborator
Author
|
Closes #1169 |
Collaborator
Author
|
Another iteration on #923 |
j-c-c
requested changes
Sep 12, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks great! Just one thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
sph_harmusing the recurrence based normalized associated Legendre polynomial method. FB3D should now operate for the same orders as FFB3D.Adds tests that compare low orders against
scipy.Checks
scipyis not finite for higher orders (they may fix one day...).Checks this implementation is finite for an order that was previously a problem.
Purges
pyshtools.