Skip to content

Remove m_* functions #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 5, 2024
Merged

Remove m_* functions #1203

merged 23 commits into from
Dec 5, 2024

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Oct 21, 2024

No description provided.

@j-c-c j-c-c added the cleanup label Oct 21, 2024
@j-c-c j-c-c self-assigned this Oct 21, 2024
@codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (6c59064) to head (2bb0858).
Report is 23 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1203      +/-   ##
===========================================
- Coverage    90.38%   90.35%   -0.04%     
===========================================
  Files          132      132              
  Lines        13754    13709      -45     
===========================================
- Hits         12432    12387      -45     
  Misses        1322     1322

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

j-c-c
j-c-c commented Nov 13, 2024
View reviewed changes
j-c-c
j-c-c commented Nov 13, 2024
View reviewed changes
j-c-c
j-c-c commented Nov 14, 2024
View reviewed changes
j-c-c
j-c-c commented Nov 14, 2024
View reviewed changes
@j-c-c j-c-c requested a review from garrettwrong November 14, 2024 20:12
garrettwrong
garrettwrong requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this forward. Had a couple questions (really just two, but one shows up in a few places).

Almost done with the m_* ! 😀

@j-c-c j-c-c requested a review from garrettwrong November 20, 2024 19:09
@garrettwrong garrettwrong marked this pull request as ready for review November 20, 2024 20:14
@garrettwrong garrettwrong requested a review from janden as a code owner November 20, 2024 20:14
garrettwrong
garrettwrong approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@garrettwrong garrettwrong mentioned this pull request Nov 21, 2024
Merged
janden
janden requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just two things.

@j-c-c j-c-c merged commit fcc0327 into develop Dec 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@garrettwrong garrettwrong garrettwrong approved these changes

Assignees

@j-c-c j-c-c

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-c-c @janden @garrettwrong