Skip to content

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Apr 1, 2025

Resolves #1253 by adding a private Image._load method that returns a numpy array of data and pixel_size and a public Image.load that returns an Image instance. The private method is used by CoordinateSource to load data from mrc/star files, which allows for rectangular micrographs.

Also, replaces a raise in Image._vx_array_to_size() with a log message to be more permissive of badly formatted headers.

@j-c-c j-c-c added the bug Something isn't working label Apr 1, 2025
@j-c-c j-c-c self-assigned this Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (4b85dd9) to head (6e86d91).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1254      +/-   ##
===========================================
+ Coverage    90.59%   90.61%   +0.01%     
===========================================
  Files          132      132              
  Lines        14136    14143       +7     
===========================================
+ Hits         12807    12815       +8     
+ Misses        1329     1328       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-c-c j-c-c marked this pull request as ready for review April 3, 2025 12:20
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a name change suggestion.

@j-c-c j-c-c merged commit 9613a2b into develop Apr 23, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants