Skip to content

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Apr 29, 2025

Adds seed parameter to BOT_align method for reproducibility. Adds seed to test to resolve flaky test.

Seeding only the volumes in the test reduced the failures to 1 in 500, down from about 3 in 100. I'll see if I can find a set of seeds that reproducibly fails.

@j-c-c j-c-c added the CI Continuous Integration label Apr 29, 2025
@j-c-c j-c-c self-assigned this Apr 29, 2025
@j-c-c j-c-c linked an issue Apr 29, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (dbad10e) to head (3770ff3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1264   +/-   ##
========================================
  Coverage    90.61%   90.61%           
========================================
  Files          132      132           
  Lines        14153    14157    +4     
========================================
+ Hits         12825    12829    +4     
  Misses        1328     1328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 😎 Hope this helps, thanks!

@j-c-c j-c-c marked this pull request as ready for review May 1, 2025 15:10
@j-c-c j-c-c requested a review from janden as a code owner May 1, 2025 15:10
@j-c-c j-c-c merged commit 6ad3ad0 into develop May 5, 2025
44 checks passed
@j-c-c j-c-c deleted the BOT branch May 5, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BOT Align Spurious Failures

4 participants