- 
                Notifications
    
You must be signed in to change notification settings  - Fork 26
 
Use scipy create_group for SymmetryGroups #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@             Coverage Diff             @@
##           develop    #1281      +/-   ##
===========================================
- Coverage    90.60%   90.58%   -0.03%     
===========================================
  Files          132      132              
  Lines        14181    14162      -19     
===========================================
- Hits         12849    12828      -21     
- Misses        1332     1334       +2     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one question. Code looks a lot lighter, thanks.
| 
           @janden, hold off on reviewing this one. I have to figure out what's going on with this failing "expensive" test.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Resolves #1275
Refactors SymmetryGroup's to use scipy create_group. Also adds icosahedral volume to synthetic volumes.