- 
                Notifications
    
You must be signed in to change notification settings  - Fork 26
 
Update Pipeline Demo #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pipeline Demo #1297
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff            @@
##           develop    #1297   +/-   ##
========================================
  Coverage    90.60%   90.60%           
========================================
  Files          133      133           
  Lines        14346    14346           
========================================
  Hits         12998    12998           
  Misses        1348     1348           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           Added additional preprocessing steps and switched to using ground truth rotations to align the volumes for FSC. Attaching a pdf of the demo as it is now.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, couple things in there. After you tweak it, send it back and I'll render it locally for another review when rendered as the webpage. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if changed, was missed before, or if I'm doing something incorrect, but when I render I get the following in Download an Example Volume
sphinx_gallery_start_ignore flake8: noqa sphinx_gallery_end_ignore
          
 Ah yeah, that needed to be in it's own cell. Fixed now. Thanks for spotting that!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks!
| 
           We should probably move on this so I can begin testing for release, thanks.  | 
    
| 
           Going to go ahead and merge this so we can try to get into release testing tomorrow after the delay.  | 
    
Updates pipeline demo to use defaults for common-lines and class averaging. Also begins with high resolution simulation. Added BOT Align and FSC.
Related #1284