Skip to content

Validate ArrayImageSource stack dimension #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

Validate ArrayImageSource stack dimension #1306

merged 2 commits into from
Aug 4, 2025

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Jul 28, 2025

Closes #1305

@garrettwrong garrettwrong requested a review from j-c-c July 28, 2025 12:37
@garrettwrong garrettwrong self-assigned this Jul 28, 2025
@garrettwrong garrettwrong added bug Something isn't working cleanup labels Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (f8f26ee) to head (d7915ba).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1306   +/-   ##
========================================
  Coverage    90.60%   90.60%           
========================================
  Files          133      133           
  Lines        14346    14348    +2     
========================================
+ Hits         12998    13000    +2     
  Misses        1348     1348

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

j-c-c
j-c-c approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong marked this pull request as ready for review July 28, 2025 17:17
@garrettwrong garrettwrong requested a review from janden as a code owner July 28, 2025 17:17
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Aug 4, 2025

This is low risk, merging to clear out the queue a little.

@garrettwrong garrettwrong merged commit 95ed9c1 into develop Aug 4, 2025
44 checks passed
@garrettwrong garrettwrong deleted the ais_shape branch October 23, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c