Skip to content

Cleanup old batch sizes#1365

Merged
garrettwrong merged 1 commit intodevelopfrom
default_batch
Mar 9, 2026
Merged

Cleanup old batch sizes#1365
garrettwrong merged 1 commit intodevelopfrom
default_batch

Conversation

@garrettwrong
Copy link
Collaborator

Update old (CPU only) batch sizes of 8192 with our preferred starting point of 512.

Adds a little blurb to cov2d docstring.

One of the action items from the cov2d comparison.

@garrettwrong garrettwrong requested a review from j-c-c March 5, 2026 20:55
@garrettwrong garrettwrong self-assigned this Mar 5, 2026
@garrettwrong garrettwrong added documentation Improvements or additions to documentation cleanup labels Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (158e2a2) to head (ce211ac).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/aspire/commands/cov3d.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1365   +/-   ##
========================================
  Coverage    90.84%   90.84%           
========================================
  Files          135      135           
  Lines        14658    14658           
========================================
  Hits         13316    13316           
  Misses        1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong garrettwrong marked this pull request as ready for review March 6, 2026 15:48
@garrettwrong garrettwrong requested a review from janden as a code owner March 6, 2026 15:48
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong merged commit fd33079 into develop Mar 9, 2026
73 of 76 checks passed
@garrettwrong garrettwrong deleted the default_batch branch March 9, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants