V estimator #845
Merged
V estimator #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
enhancement
Codecov Report
@@ Coverage Diff @@
## abinitio_cn #845 +/- ##
===============================================
+ Coverage 86.90% 86.94% +0.04%
===============================================
Files 114 114
Lines 9085 9118 +33
===============================================
+ Hits 7895 7928 +33
Misses 1190 1190
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coded up the median sign group mean we discussed yesterday for Cn out product estimation. It also has the mean and var fwiw.
Feel free to rename things if you end up proceeding in this direction. I didn't spend any time thinking about good names.
Even if you don't take the median approach, it might be useful to use something like this for the code so that we decouple this estimation (and all the supporting code/tests) from being in the middle of the other algorithm. This will also make it easier to change in the future, so long as the
pushsemantic will work for you... since we're in agreement there is work to do here.If we really want to take a straight median there isn't really a way around accumulating all the arrays (not the end of the world).