-
Notifications
You must be signed in to change notification settings - Fork 26
Class Source #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Class Source #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some loosely based on matlab code
Codecov Report
@@ Coverage Diff @@
## develop #866 +/- ##
===========================================
- Coverage 88.62% 88.42% -0.20%
===========================================
Files 117 119 +2
Lines 9591 10309 +718
===========================================
+ Hits 8500 9116 +616
- Misses 1091 1193 +102
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
implemented but unused in MATLAB
|
Hit all the remarks, but I'll need to proofread with fresh eyes later or tomorrow. Codeblind right now. |
janden
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch of class source architecture. IncludesClassAvgSource, local and globalClassSelector,ImageQualityFunctionbase classes and some concrete implementations.Still a lot of work to do shaking out bugs, corner cases, deciding on names/defaults, and potentially some questions for Joakim/Yoel/Amit.Proposed
ClassAvgSourcearchitecture, associated components and docs.Note it's known some of the tests are lacking, but I think it would be best to focus test efforts on whatever actually makes it into
developas a follow-up. I did go ahead and write up explicit docs now just because the components are many and in my head atm.