Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Feb 24, 2023

Sketch of class source architecture. Includes ClassAvgSource, local and global ClassSelector, ImageQualityFunction base classes and some concrete implementations.

Still a lot of work to do shaking out bugs, corner cases, deciding on names/defaults, and potentially some questions for Joakim/Yoel/Amit.

Proposed ClassAvgSource architecture, associated components and docs.

Note it's known some of the tests are lacking, but I think it would be best to focus test efforts on whatever actually makes it into develop as a follow-up. I did go ahead and write up explicit docs now just because the components are many and in my head atm.

@garrettwrong garrettwrong added the enhancement New feature or request label Feb 24, 2023
@garrettwrong garrettwrong self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #866 (e09d61e) into develop (0274272) will decrease coverage by 0.20%.
The diff coverage is 75.11%.

@@             Coverage Diff             @@
##           develop     #866      +/-   ##
===========================================
- Coverage    88.62%   88.42%   -0.20%     
===========================================
  Files          117      119       +2     
  Lines         9591    10309     +718     
===========================================
+ Hits          8500     9116     +616     
- Misses        1091     1193     +102     
Impacted Files Coverage Δ
src/aspire/classification/class2d.py 93.75% <ø> (-0.99%) ⬇️
src/aspire/classification/class_selection.py 62.79% <61.96%> (-37.21%) ⬇️
src/aspire/denoising/class_avg.py 74.21% <73.80%> (+74.21%) ⬆️
src/aspire/source/image.py 90.97% <87.50%> (-0.16%) ⬇️
src/aspire/classification/rir_class2d.py 95.62% <89.47%> (+0.44%) ⬆️
src/aspire/image/image_stacker.py 93.15% <93.15%> (ø)
src/aspire/classification/averager2d.py 80.07% <95.23%> (+0.67%) ⬆️
src/aspire/classification/__init__.py 100.00% <100.00%> (ø)
src/aspire/denoising/__init__.py 100.00% <100.00%> (ø)
src/aspire/denoising/denoised_src.py 92.30% <100.00%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong
Copy link
Collaborator Author

Hit all the remarks, but I'll need to proofread with fresh eyes later or tomorrow. Codeblind right now.

@garrettwrong garrettwrong requested a review from janden March 31, 2023 14:39
@garrettwrong garrettwrong merged commit ccd044c into develop Apr 5, 2023
@garrettwrong garrettwrong deleted the class_src branch April 5, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants