Skip to content

xfail FLE test broken on windows (only on windows). #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

xfail FLE test broken on windows (only on windows). #868

merged 1 commit into from
Feb 27, 2023

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Feb 27, 2023

Workaround #862

@garrettwrong garrettwrong added the bug Something isn't working label Feb 27, 2023
@garrettwrong garrettwrong requested a review from j-c-c February 27, 2023 17:07
@garrettwrong garrettwrong self-assigned this Feb 27, 2023
@garrettwrong garrettwrong marked this pull request as ready for review February 27, 2023 17:19
@garrettwrong garrettwrong requested a review from janden as a code owner February 27, 2023 17:19
@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #868 (1e58cdd) into develop (e9d5e91) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #868      +/-   ##
===========================================
+ Coverage    88.69%   88.71%   +0.01%     
===========================================
  Files          116      116              
  Lines         9440     9464      +24     
===========================================
+ Hits          8373     8396      +23     
- Misses        1067     1068       +1
Impacted Files Coverage Δ
src/aspire/ctf/ctf_estimator.py 98.14% <0.00%> (-0.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

j-c-c
j-c-c approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@garrettwrong garrettwrong merged commit 22ca173 into develop Feb 27, 2023
@garrettwrong garrettwrong deleted the fle_xfail branch February 27, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c