Skip to content

Minor ctf tweaks #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2023
Merged

Minor ctf tweaks #870

merged 4 commits into from
Mar 1, 2023

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Feb 28, 2023

Fixed typo in unit test and added note about astigmatism values following discussion with Amit.

@garrettwrong garrettwrong added bug Something isn't working documentation Improvements or additions to documentation cleanup labels Feb 28, 2023
@garrettwrong garrettwrong requested a review from j-c-c February 28, 2023 13:27
@garrettwrong garrettwrong self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #870 (3580ef2) into develop (22ca173) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #870      +/-   ##
===========================================
- Coverage    88.69%   88.68%   -0.02%     
===========================================
  Files          116      116              
  Lines         9440     9439       -1     
===========================================
- Hits          8373     8371       -2     
- Misses        1067     1068       +1
Impacted Files Coverage Δ
src/aspire/ctf/ctf_estimator.py 98.01% <50.00%> (-0.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong @j-c-c
Exclude bounds from CTFEstimator linprog
35821c1 
Co-authored-by: Josh Carmichael <carmichael@princeton.edu>
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Feb 28, 2023

Also works around an issue discovered in CI, related to #417 .

j-c-c
j-c-c previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a typo.

@garrettwrong garrettwrong marked this pull request as ready for review March 1, 2023 13:14
@garrettwrong garrettwrong requested a review from janden as a code owner March 1, 2023 13:14
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Mar 1, 2023

Once the CI passes, pushing to merge this so i) the daily docs build again ii) the typos are fixed before our lecture demo.

We can follow up re the ctf linear programming bug(s) in a team meeting.

@garrettwrong garrettwrong merged commit b60c0ee into develop Mar 1, 2023
@garrettwrong garrettwrong deleted the minor_ctf_tweaks branch March 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c left review comments

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working cleanup documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c