Initial addition of RemappedSource #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #877 +/- ##
===========================================
+ Coverage 88.62% 89.22% +0.60%
===========================================
Files 116 117 +1
Lines 9363 10182 +819
===========================================
+ Hits 8298 9085 +787
- Misses 1065 1097 +32
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
Noting this doesn't update the tutorials. It will be much easier to do that as a small follow after some of the PRs are merged. |
j-c-c
previously approved these changes
Mar 14, 2023
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
This looks great! The code comments were very helpful. It will be nice to A/B some experiments!
Collaborator
Author
|
Cool, let's confirm the design with Joakim then move to merge it. |
janden
requested changes
Mar 16, 2023
Collaborator
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Nice! Can't wait for immutable Sources…
janden
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #876 . Open to alternatives, but I think this solves the immediate problem. It can be refined more as part of the upcoming immutable Source effort.