-
Notifications
You must be signed in to change notification settings - Fork 26
Missed img vol return tutorial updates #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
19c6bc2 to
6effd68
Compare
Codecov Report
@@ Coverage Diff @@
## develop #884 +/- ##
===========================================
- Coverage 88.70% 88.63% -0.07%
===========================================
Files 117 117
Lines 9788 9575 -213
===========================================
- Hits 8682 8487 -195
+ Misses 1106 1088 -18
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Moving to merge this so Discussed converting the older scripts towards using the gallery formatting so we can just avoid the ugly subplot usage. (Will make an issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Aside from the one vol plot in experimental I couldn't find any other instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There's an interesting point here, though: we have to call copy on the ndarrays returned by asnumpy to avoid modifying the original Image? We may want to consider forcing asnumpy to make a copy (or to mark it read-only) to avoid this issue. This may be less important to Images, but when they're part of a source, we certainly don't want people to go around modifying them by accident (especially if the sources are to be seen as immutable).
|
I agree that is a concern. Disabling writable is probably the best compromise to avoid unneeded deep copies. I'll put that together. Thanks! https://numpy.org/doc/stable/reference/generated/numpy.ndarray.flags.html |
Somehow these were missed.
We will be adding doc building to the CI jobs that run on "Review" readiness, since I forgot these (my bad).