Skip to content

Asnumpy writable #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2023
Merged

Asnumpy writable #888

merged 4 commits into from
Mar 21, 2023

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Mar 21, 2023

Closes #887

@garrettwrong garrettwrong requested a review from j-c-c March 21, 2023 12:38
@garrettwrong garrettwrong self-assigned this Mar 21, 2023
@garrettwrong garrettwrong added enhancement New feature or request good first issue Good for newcomers cleanup labels Mar 21, 2023
@garrettwrong garrettwrong marked this pull request as ready for review March 21, 2023 12:39
@garrettwrong garrettwrong requested a review from janden as a code owner March 21, 2023 12:39
@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #888 (9a841b6) into develop (ff274fa) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #888      +/-   ##
===========================================
- Coverage    88.63%   88.60%   -0.03%     
===========================================
  Files          117      117              
  Lines         9575     9578       +3     
===========================================
  Hits          8487     8487              
- Misses        1088     1091       +3
Impacted Files Coverage Δ
src/aspire/ctf/ctf_estimator.py 98.01% <100.00%> (ø)
src/aspire/image/image.py 92.41% <100.00%> (+0.06%) ⬆️
src/aspire/volume/volume.py 91.94% <100.00%> (+0.06%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

j-c-c
j-c-c previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

janden
janden requested changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can probably revert the change to

ASPIRE-Python/gallery/tutorials/basic_image_array.py

Line 134 in 61450dd

noisy_imgs_copy = imgs_src.images[:n_imgs].asnumpy().copy()
while you're here.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Mar 21, 2023

Sure thing, got it. Thanks

@garrettwrong garrettwrong requested a review from janden March 21, 2023 14:56
@garrettwrong garrettwrong merged commit e9c9586 into develop Mar 21, 2023
@garrettwrong garrettwrong deleted the asnumpy_writable branch March 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@j-c-c j-c-c j-c-c left review comments

Assignees

@garrettwrong garrettwrong

Labels

cleanup enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettwrong @janden @j-c-c