Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Found several small patches going through some documentation/tutorial updates in upstream branches. Cherrypicked into this small pr.

i) rotations dtypes were not enforced and potentially getting mixed
ii) metadata should be copied in case we get a pandas view
iii) filter indices and default identity filter for IndexedSource, same as ArrayImageSource
iv) forgot to call self's generation pipeline in IndexedSource

@garrettwrong garrettwrong added the bug Something isn't working label Mar 22, 2023
@garrettwrong garrettwrong self-assigned this Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #891 (c0ece23) into develop (e9c9586) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #891      +/-   ##
===========================================
+ Coverage    88.58%   88.64%   +0.06%     
===========================================
  Files          117      117              
  Lines         9575     9583       +8     
===========================================
+ Hits          8482     8495      +13     
+ Misses        1093     1088       -5     
Impacted Files Coverage Δ
src/aspire/source/image.py 91.70% <100.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong garrettwrong marked this pull request as ready for review March 23, 2023 13:20
@garrettwrong garrettwrong requested a review from janden as a code owner March 23, 2023 13:20
@garrettwrong garrettwrong merged commit e10cbe6 into develop Mar 23, 2023
@garrettwrong garrettwrong deleted the src_patches branch March 23, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants