test expected to fail #909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #909 +/- ##
========================================
Coverage 88.18% 88.18%
========================================
Files 119 119
Lines 10118 10118
========================================
Hits 8923 8923
Misses 1195 1195 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks Vineet. Can you point me to to spec you are referencing? Here I don't see anything specific (which makes me think your proposed fix is safer), but I'm curious if Relion actually allows this situation. (forgot to paste link) https://relion.readthedocs.io/en/release-3.1/Reference/Conventions.html#optics-groups |
|
Oh - that was the document I was referring to (the line "..refer to an optics group entry in the optics table via the rlnOpticsGroup column"). I don't know of the official spec beyond that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While moving the relion code from
pandasto straight dicts, I noticed what looks to me like a bug in the way the optics properties are expanded by optics group lookup (unless I'm misunderstanding the spec). The current implementation is assuming ordered rows in thedata_opticstable that go from 1-n as far as_rlnOpticsGroupis concerned. Swapping (or shuffling in the general case) the rows should have no effect, but does, as is demonstrated by the failing test here.I'm breaking this into two PRs so they're easier to reason through - one for the expected failing test, the other for the fix that takes the
xfailoff.