Skip to content

Env fix#40

Open
matthewlefler wants to merge 9 commits intomasterfrom
env-fix
Open

Env fix#40
matthewlefler wants to merge 9 commits intomasterfrom
env-fix

Conversation

@matthewlefler
Copy link
Copy Markdown

What

  • app.rs
    • get_app_data()
      • use env variables given in template in README.md
  • test files
    • changes all api request routes from route to api/route
  • dockerfiles
    • rust:1.70-slim-buster -> rust:1.94.0-slim-trixie for
      • /Dockerfile
      • /Dockerfile.test
      • /Dockerfile.local
  • docker compose files
    • use new env variables in devcade-api environment for
      • docker-compose.yml
      • docker-compose.test.yml

Why

Application did not use the environmental variables stated in the README.md
Tests did not run correctly all throwing 404 errors

Test Plan

Ran tests using

sudo docker compose -f docker-compose.test.yml run --rm devcade-api

Env Vars

Changed

  • DOMAIN to ALLOWED_ORIGIN
    • to better match the purpose of it and to increase readability
      replaced
  • SQL_URI with
    • PSQL_PORT
    • PSQL_USER
    • PSQL_PASS
    • PSQL_URI

Documentation

added env.template copy paste instructions to README.md
added testing section and example command to README.md

Checklist

  • Tested all changes locally
    Runs, tests fail but this is due to most likely previous PRs making the test code invalid, not something this PR touched
    test result: FAILED. 32 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s

@matthewlefler
Copy link
Copy Markdown
Author

matthewlefler commented Apr 22, 2026

Guess i updated the dependencies too. whoops.
cargo update goes brrr ig

@matthewlefler
Copy link
Copy Markdown
Author

note: updated routes doc url bc its a simple oneline change

@matthewlefler matthewlefler linked an issue Apr 22, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs are all wrong

1 participant