-
Notifications
You must be signed in to change notification settings - Fork 6
Update repo + Docker #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tallen42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left changes on specific files, but overall this is a great QOL upgrade to Jumpstart! Thank you so much :)
tallen42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fire changes thank you so much! One last note w/ launching the app and we're good.
|
@tallen42 Should we do anything about newer versions of flask_limiter requiring a storage backend to store limits? https://flask-limiter.readthedocs.io/en/stable/#configuring-a-storage-backend Docs note that in-memory storage is for development only, but doesn't elaborate about why this is the case |
|
What are we storing in memory? |
|
Before updating flask_limiter, all rate-limiting data was stored in memory, but now flask_limiter moved to persistent storage methods like memcached, mongodb, redis, etc. It still supports in-memory storage, but says it shouldn't be used in production and gives no reason why. Not sure if it's just over complicating a simple issue or not. |
tallen42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
All dependencies were updated to latest, project now supports latest python (3.13).
Added dockerfile and documentation.
Also fixed up readme and added additional info.