Added 6 new Colors #139
Merged
Added 6 new Colors #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/develop Data dump fix
bgrawi
requested changes
Nov 1, 2017
| "#658B76", | ||
| "#92838F", | ||
| "#A9ABC3", | ||
| "#7c7fa4", |
There was a problem hiding this comment.
I would say just uppercase the letters in these so that it looks more consistent
| @@ -1,10 +1,10 @@ | |||
| angular.module('sm').controller("AppController", function($scope, localStorage, $window, $filter, $state, $stateParams) { | |||
There was a problem hiding this comment.
Normally I'd say keep all formatting-related changes in their own commit, but this is fine because I see no reason we would ever revert this.
There was a problem hiding this comment.
So this was a mistake where vim had retab on, was not intentional
There was a problem hiding this comment.
Always check diffs before making the PR 😄
bgrawi
approved these changes
Nov 1, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 6 new Colors to fix #132. I only added 6 because after that finding complementary colors was a little difficult
Also added a version bump to allow changes to take effect