Adding check to prevent generating 10000 Schedules #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a simple check that before actually running through a result, PHP stops and returns an error
bgrawi
requested changes
Mar 28, 2018
api/generate.php
Outdated
| $totalSchedules *= count($_POST["courses{$i}Opt"]); | ||
| } | ||
| if ($totalSchedules >= 10000){ | ||
| echo json_encode(array("error" => "argument", "msg" => "Too many schedule possibilities to generate, try to prune possibilities. |
There was a problem hiding this comment.
I would word this differently, "prune possibilities" -> "remove class sections you know you don't want from your cart" or something that flows better :)
bgrawi
approved these changes
Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple check that before actually running through a result, PHP stops and returns an error
This will prevent super large schedules from being generated, as well as reducing processing on the sever from people generating the super large options.
Fixes #133