Skip to content

Adding check to prevent generating 10000 Schedules #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Adding check to prevent generating 10000 Schedules #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638e250
Adding check to prevent generating 10000 Schedules
devinmatte Mar 28, 2018
1ae6d8f
Fixing phrasing
devinmatte Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions api/generate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,19 @@ function pruneSpecialCourses($schedules, $courseGroups) {
$courseGroupsByCourseId = array();

$courseSet = array();

// Check to make sure schedule wont exceed 10,000 options
$totalSchedules = 1;
for($i = 1; $i <= $_POST['courseCount']; $i++) {
if(!isset($_POST["courses{$i}Opt"])) { continue; }
$totalSchedules *= count($_POST["courses{$i}Opt"]);
}
if ($totalSchedules >= 10000){
echo json_encode(array("error" => "argument", "msg" => "Too many schedule possibilities to generate, try to remove classes from your shopping cart.
Adding classes like YearOne or classes with hundreds of sections can cause this to occur.", "arg" => "action"));
break;
}

for($i = 1; $i <= $_POST['courseCount']; $i++) { // It's 1-indexed... :[
// Iterate over the courses in that course slot
if(!isset($_POST["courses{$i}Opt"])) { continue; }
Expand Down