Moving Schedulemaker to Openshift #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenmirabito
requested changes
Apr 17, 2018
inc/config.env.php
Outdated
| $DATABASE_USER = $get_env(getenv("DATABASE_USER"), ''); | ||
| $DATABASE_PASS = $get_env(getenv("DATABASE_PASS"), ''); | ||
| $DATABASE_DB = $get_env(getenv("DATABASE_DB"), ''); | ||
| $DUMPCLASSES = '/mnt/share/cshclass.dat'; |
There was a problem hiding this comment.
These will also likely need to be configurable, with a default such as /data
Dockerfile
Outdated
| FROM php:7.1-apache | ||
| MAINTAINER Devin Matte <matted@csh.rit.edu> | ||
|
|
||
| EXPOSE 8080 |
There was a problem hiding this comment.
EXPOSE statements are typically at the end of the file
Dockerfile
Outdated
| ADD apache-config.conf /etc/apache2/sites-enabled/000-default.conf | ||
|
|
||
| RUN apt-get -yq update && \ | ||
| apt-get -yq install gnupg libmagickwand-dev --no-install-recommends |
There was a problem hiding this comment.
Need to run apt-get -yq clean all here
Dockerfile
Outdated
|
|
||
| RUN a2enmod rewrite && a2enmod headers && a2enmod expires | ||
|
|
||
| RUN sed -i '/Listen/{s/\([0-9]\+\)/8080/; :a;n; ba}' /etc/apache2/ports.conf |
There was a problem hiding this comment.
Combine both of these RUN statements, along with the RUN statement at the end of the file (do all Apache config in a single RUN statement)
Dockerfile
Outdated
| apt-get -yq install gnupg libmagickwand-dev --no-install-recommends | ||
|
|
||
| RUN docker-php-ext-install mysqli | ||
| RUN pecl install imagick && docker-php-ext-enable imagick |
Dockerfile
Outdated
| npm install && \ | ||
| npm run-script build && \ | ||
| rm -rf node_modules && \ | ||
| apt-get -yq remove nodejs npm && \ |
There was a problem hiding this comment.
You're not installing npm, does the package stay behind when nodejs is removed? Otherwise, remove it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting ready to move far away from Yasuko for almost all web projects. This is the first stage in getting schedulemaker off of Yasuko, and onto openshift.
We're first starting by moving schedulemaker-dev. Currently everything except for running the cron for parsing. That's in the works and should be done soon.