Skip to content

Conversation

@mbillow
Copy link
Member

@mbillow mbillow commented Sep 1, 2020

I fixed the docker container. 🎉
Fixed #177

@mbillow mbillow requested a review from devinmatte September 1, 2020 18:18
@mbillow mbillow requested a review from a team as a code owner September 1, 2020 18:18

RUN wget https://github.com/ImageMagick/ImageMagick6/archive/6.9.11-22.tar.gz && \
tar -xzvf 6.9.11-22.tar.gz && \
cd ImageMagick6-6.9.11-22 && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably clean up the tar file and source folder.


RUN apt-get -yq update && \
apt-get -yq install gnupg libmagickwand-dev git gcc make autoconf libc-dev pkg-config --no-install-recommends
apt-get -yq install \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be sorted in alphabetical order.

Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this. Next step is to move to multistage builds

@devinmatte devinmatte merged commit 728819f into develop Sep 1, 2020
@devinmatte devinmatte deleted the mbillow/fix-dockerfile branch September 1, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save as Image produces blank image

3 participants