Skip to content

Pylint and role fixes#33

Merged
mxmeinhold merged 7 commits intoComputerScienceHouse:developfrom
mxmeinhold:pylint-and-role-fixes
May 25, 2020
Merged

Pylint and role fixes#33
mxmeinhold merged 7 commits intoComputerScienceHouse:developfrom
mxmeinhold:pylint-and-role-fixes

Conversation

@mxmeinhold
Copy link
Contributor

The 500 errors if you weren't in a group seemed in poor taste, so let's use the flash configuration we already had.
Adds various fixes to role checking.

Examples:

Fewer raw string error messages

Fancy flash when you do something you shouldn't be doing
'Not Evals or an RTP' flash

Fewer 500 errors

Now the index loads even if you're not on a team
'You are not in a group' error flash

Includes all applications list for RTPs and Evals
Index view for RTP or Evals when not in a group, showing the listing of all applications

P.S.

Fewer pylint errors

Pylint output, with 0 errors and a rating of 10.00/10

Quote standardization

travis.yaml script section, including quote linti

Why?

I was annoyed. This is purely out of spite.

@mxmeinhold mxmeinhold mentioned this pull request May 17, 2020
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright go for it

@mxmeinhold mxmeinhold merged commit afe5e9b into ComputerScienceHouse:develop May 25, 2020
@mxmeinhold mxmeinhold deleted the pylint-and-role-fixes branch May 25, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants