Conversation
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
tallen42
approved these changes
Apr 18, 2026
Contributor
tallen42
left a comment
tallen42
left a comment
There was a problem hiding this comment.
no more object object. thank you javascript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Okay so in the beginning I was like "why is there an array??" which is where the bug was introduced: we're iterating over an array containing the new votes, not the actual options and their counts. Ranked Choice is where the problem is.
So what does this PR do?
Why
0: object Object
Test Plan
Env Vars
N/A
Documentation
Bug fix, N/A
Checklist