Added callback beforeClose and beforeOpen#82
Merged
ComputerWolf merged 2 commits intoComputerWolf:masterfrom Apr 23, 2015
Merged
Added callback beforeClose and beforeOpen#82ComputerWolf merged 2 commits intoComputerWolf:masterfrom
ComputerWolf merged 2 commits intoComputerWolf:masterfrom
Conversation
added 2 commits
April 23, 2015 11:50
If you want e.g. change the background of the menu when it´s open, you would normally do it with the open callback. But then the background changes AFTER the menu is opened. So the user got a flickering of the change for the duration of the animation. So I added the beforeClose and the beforeOpen callback.
ComputerWolf
added a commit
that referenced
this pull request
Apr 23, 2015
Added callback beforeClose and beforeOpen
Contributor
Author
|
Please consider of this adding to your documentation, cause the old callbacks are not working anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want e.g. change the background of the menu when it´s open, you would normally do it with the open callback. But then the background changes AFTER the menu is opened. So the user got a flickering of the change for the duration of the animation. So I added the beforeClose and the beforeOpen callback.