Skip to content

feat(clubList): search#518

Merged
qwerzl merged 5 commits intoComputerization:nextfrom
at-wr:club-search-dev
Mar 15, 2024
Merged

feat(clubList): search#518
qwerzl merged 5 commits intoComputerization:nextfrom
at-wr:club-search-dev

Conversation

@at-wr
Copy link
Member

@at-wr at-wr commented Mar 10, 2024

This PR contains a brand new feature which allows user to search clubs in /cas/club via its English or Chinese name while ignoring its capitalization. While there's searchTerm in the search box, Tabs will be disabled.

Such actions will be processed within user's browser without contacting the server.

Other project: #485

Known Issue

  • (Fixed) * and \ may trigger 500 error page becuz of the usage of regex

@netlify
Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for computerization-enspire-next ready!

Name Link
🔨 Latest commit 03789f3
🔍 Latest deploy log https://app.netlify.com/sites/computerization-enspire-next/deploys/65f3a42fb64cad00089c1a80
😎 Deploy Preview https://deploy-preview-518--computerization-enspire-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-wr at-wr changed the title feat: search for club in either English or Chinese feat: club searching Mar 10, 2024
@at-wr at-wr changed the title feat: club searching feat: club search feature for clubList Mar 12, 2024
@qwerzl qwerzl changed the title feat: club search feature for clubList feat(clubList): search Mar 15, 2024
@qwerzl qwerzl merged commit 12e8892 into Computerization:next Mar 15, 2024
@qwerzl
Copy link
Member

qwerzl commented Mar 15, 2024

Done. Added icon to the tab list and hided text on small screens so the tab list would be much shorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants