Skip to content

Add docs on CI/CD infrastructure#376

Merged
yechs merged 5 commits intomasterfrom
yechs/docs-infra
Jul 2, 2021
Merged

Add docs on CI/CD infrastructure#376
yechs merged 5 commits intomasterfrom
yechs/docs-infra

Conversation

@yechs
Copy link
Copy Markdown
Member

@yechs yechs commented Jul 1, 2021

No description provided.

@yechs yechs added the documentation Improvements or additions to documentation label Jul 1, 2021
@yechs yechs requested a review from Josh-Cena July 1, 2021 14:48
@yechs yechs self-assigned this Jul 1, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 1, 2021 •
edited
Loading

✔️ Deploy preview built successfully 🎉

🔨 Explore the source changes: 8eea802

🔍 Inspect the deploy log: https://app.netlify.com/sites/computerization/deploys/60df1ed5449ff600074c3052

😎 Browse the preview: https://deploy-preview-376--computerization.netlify.app

@yechs
Copy link
Copy Markdown
Member Author

yechs commented Jul 1, 2021

TODO: Add English l10n (probably by this weekend)

@yechs
Copy link
Copy Markdown
Member Author

yechs commented Jul 1, 2021

@Josh-Cena 顺带我跑了一遍 yarn run write-heading-ids 生成了一些奇怪的 headings，这些东西有用吗……？没有的话我之后删掉？

@Josh-Cena
Copy link
Copy Markdown
Member

Josh-Cena commented Jul 1, 2021

@Josh-Cena 顺带我跑了一遍 yarn run write-heading-ids 生成了一些奇怪的 headings，这些东西有用吗……？没有的话我之后删掉？

其实 explicit headings 的用处是在正文为中文时保持使用英语 heading……除此以外，可能对 SEO 有影响（？

我们先等英语版写好之后再调 heading 内容吧

@Josh-Cena
Copy link
Copy Markdown
Member

Josh-Cena commented Jul 1, 2021

其实我是希望把这个文档放在 Enspire 目录下面的，看起来会充实一点，WDYT？

@yechs
Copy link
Copy Markdown
Member Author

yechs commented Jul 1, 2021

其实我是希望把这个文档放在 Enspire 目录下面的，看起来会充实一点，WDYT？

主要我觉得这些东西适用的不仅仅是 Enspire，在这个项目下面（以及未来的许多项目）也都适用，所以新建了一个 infra 的目录

除此之外，还有很多其它的 infra 的文档应该也可以被加到这里面（比如服务器、数据库、build system、git 之类的）

@Josh-Cena
Copy link
Copy Markdown
Member

Josh-Cena commented Jul 2, 2021

还有，你的 headings 崩了_(:з」∠)_因为 heading id 是直接放在 URL 里面的，所以不能出现非 ASCII 字符，理论上渲染的时候是不会出现的

@yechs
Copy link
Copy Markdown
Member Author

yechs commented Jul 2, 2021

还有，你的 headings 崩了_(:з」∠)_因为 heading id 是直接放在 URL 里面的，所以不能出现非 ASCII 字符，理论上渲染的时候是不会出现的

啊……那我下个 commit 把它们去掉好了

@Josh-Cena
Copy link
Copy Markdown
Member

Josh-Cena commented Jul 2, 2021

还有，你的 headings 崩了_(:з」∠)_因为 heading id 是直接放在 URL 里面的，所以不能出现非 ASCII 字符，理论上渲染的时候是不会出现的

啊……那我下个 commit 把它们去掉好了

还是得有的，因为page anchor URL会用到，改成英语就好了

@yechs
Copy link
Copy Markdown
Member Author

yechs commented Jul 2, 2021

还是得有的，因为page anchor URL会用到，改成英语就好了

啊这，我刚看到，我还想吐槽怎么英语的就可以，中文的 ID 就 gg

@yechs yechs marked this pull request as ready for review July 2, 2021 13:04
@Josh-Cena
Miscellaneous changes
8eea802 
Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
yechs
yechs commented Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member Author

@yechs yechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commit looks good to me. Will merge as soon as you approve

@yechs yechs merged commit 307da84 into master Jul 2, 2021
@yechs yechs deleted the yechs/docs-infra branch July 2, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees

@yechs yechs

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yechs @Josh-Cena