fix: Correctly reporting unknown solution in optimisation and solution enumeration #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenflippo
approved these changes
Jul 10, 2025
This was referenced Jul 10, 2025
ImkoMarijnissen
added a commit
that referenced
this pull request
Nov 10, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.2](pumpkin-core-v0.2.1...pumpkin-core-v0.2.2) (2025-11-10) ### Features * Adding logging of brancher statistics on completion ([#257](#257)) ([9d26842](9d26842)) * Post equality as single predicate instead of splitting in two ([#305](#305)) ([8f43208](8f43208)) * Adding edge-finding for the disjunctive constraint ([#275](#275)) ([606a7d8](606a7d8)) * Lazy explanation for linear less than or equals ([#290](#290)) ([3515c7a](3515c7a)) * Write proofs with gzip encoding ([#264](#264)) ([83f76da](83f76da)) * Remove unnecessary variables introduced by bool2int ([#232](#232)) ([cf0b2fe](cf0b2fe)) * Use lazy explanations for BinaryEq ([#231](#231)) ([4a89a5e](4a89a5e)) * Support warm_start and ignore constraint_name search annotations ([#235](#235)) ([d7e8bb0](d7e8bb0)) ### Bug Fixes * Add pumpkin-crates to default-members ([#286](#286)) ([bf7ff80](bf7ff80)) * Correctly reporting unknown solution in optimisation and solution enumeration ([#247](#247)) ([8c0f27c](8c0f27c)) * Create correct reason for preprocessing permanent nogood + Removing unassigned status for PredicateId ([#250](#250)) ([98ba136](98ba136)) * Provide `SelectionContext` instead of `Assignments` to `Brancher::synchronise` ([#312](#312)) ([9548114](9548114)) * Remove debug printing ([#254](#254)) ([0ca93a2](0ca93a2)) * Remove the terms with zero coefficients from linear constraints ([#269](#269)) ([576887e](576887e)) * Take root-propagation into account in the LUS optimiser ([#253](#253)) ([d30ed06](d30ed06)) * Reduce cost of predicate notification ([#259](#259)) ([d38e990](d38e990)) ### Refactors * Avoid unnecessary traversals of profiles in time-tabling + Improving Explanations ([#282](#282)) ([f7a4fdb](f7a4fdb)) * Don't use binary equals when logging the full proof ([#252](#252)) ([4454d93](4454d93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Imko Marijnissen <imko.marijnissen@gmail.com>
ImkoMarijnissen
added a commit
that referenced
this pull request
Nov 10, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.2](pumpkin-solver-v0.2.1...pumpkin-solver-v0.2.2) (2025-11-10) ### Features * Adding logging of brancher statistics on completion ([#257](#257)) ([9d26842](9d26842)) * Allow unbounded integers in FlatZinc models ([#285](#285)) ([826fe58](826fe58)) * Adding disjunctive to the FlatZinc interface ([#275](#275)) ([606a7d8](606a7d8)) ### Bug Fixes * Allow bool in int search strategy ([#308](#308)) ([a3fb929](a3fb929)) * Correctly reporting unknown solution in optimisation and solution enumeration ([#247](#247)) ([8c0f27c](8c0f27c)) * Only compile solution checkers for integration tests ([#278](#278)) ([a5e4c2c](a5e4c2c)) * Support warm_start and ignore constraint_name search annotations ([#235](#235)) ([d7e8bb0](d7e8bb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Imko Marijnissen <imko.marijnissen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.