packaging rpm: use non legacy compat action post upgrade#237
Merged
sni merged 1 commit intoConSol-Monitoring:mainfrom May 20, 2025
BlackIkeEagle:rpm-systemd-post
Merged
packaging rpm: use non legacy compat action post upgrade#237sni merged 1 commit intoConSol-Monitoring:mainfrom BlackIkeEagle:rpm-systemd-post
sni merged 1 commit intoConSol-Monitoring:mainfrom
BlackIkeEagle:rpm-systemd-post
Conversation
Since everything in the specfile is using systemd, there is no need to use the compatibility action `condrestart` but we can actually use the documented `try-restart` action which will yield the same result of restarting the service when it is started or leave it alone if it was not yet started. Signed-off-by: BlackEagle <ike.devolder@gmail.com>
sni
approved these changes
May 20, 2025
Contributor
|
looks good. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since everything in the specfile is using systemd, there is no need to use the compatibility action
condrestartbut we can actually use the documentedtry-restartaction which will yield the same result of restarting the service when it is started or leave it alone if it was not yet started.