[codex] Harden TaskBound action install path#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the Action publishing path after the live demo showed the self-dogfood workflow could execute PR-modified npm lifecycle scripts when using
uses: ./.Changes:
npm ci --ignore-scriptsandnpm run build --ignore-scriptsinside the composite Action install/build steps.uses: ./toConalh/TaskBound@main, while keeping PR title/body task fallback coverage.0.2.0so the next release tag can match the advertised Action behavior.Root cause
PR #1 intentionally modifies
package.jsonwith apostinstallpipe-to-shell script. The self-dogfood workflow useduses: ./, so GitHub Actions evaluated the local Action from the PR merge checkout and rannpm cifrom that checkout. The log showed the demopostinstallcommand executing before TaskBound reviewed the diff.Validation
node --test test/workflow.test.mjspassed.npm run buildpassed.npm testpassed: 22/22.git diff --checkpassed, with Windows CRLF conversion warnings only.