feat(p3-citizen-participation): apply spec (partial — i18n deferred)#173
Merged
Merged
Conversation
Applies the openspec change for p3-citizen-participation. NOTE: i18n keys deferred to a follow-up — the apply agent stalled mid-i18n update. Changes: - decidesk_register.json: +7 schemas (BudgetProposal, CitizenPanel, CitizenVote, Deliberation, Notification, ParticipatoryBudget, PublicConsultation); Decision.isPublished promoted to enum (internal | public | confidential). - DecisionController/LiveDecisionService: handle isPublished enum (treats legacy boolean true as already-published for backward compat). - Tests updated: 24 schemas expected; publish() tests use enum values. i18n update for new schemas/strings is deferred to a follow-up PR.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 469/469 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/115 statements)
Quality workflow — 2026-05-11 05:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the openspec change for p3-citizen-participation to the decidesk register, controller, and tests. The original apply agent stalled mid-i18n update, so this PR lands the structural/code portion only — i18n key updates are deferred to a follow-up.
Changes
lib/Settings/decidesk_register.json— adds 7 schemas for citizen engagement (BudgetProposal,CitizenPanel,CitizenVote,Deliberation,Notification,ParticipatoryBudget,PublicConsultation). PromotesDecision.isPublishedfrombooleanto enuminternal | public | confidential.lib/Controller/DecisionController.php+lib/Service/LiveDecisionService.php— handle newisPublishedenum; backwards-compatible with legacy boolean form.tests/Unit/RegisterJsonTest.php— schema count expectation raised from 17 to 24 (17 p1 core + 7 p3); enum assertion added.tests/Unit/Controller/DecisionControllerTest.php— publish() tests updated to use enum values.src/manifest.json— minor cache-buster bump.Deferred
Quality gates
composer check:strict— passes (lint, phpcs, phpmd, psalm, phpstan, phpunit 153 tests / 822 assertions / 33 skipped)npm ci— clean installnpm run lint— 0 errors (17 pre-existing warnings)npm run build— webpack compiled with 4 pre-existing warnings (no errors)Test plan
isPublishedenum labels