Skip to content

chore(openspec): cleanup p2-mad-core-t1 + add legacy-quality design.md#177

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/decidesk-last-2-complete
May 11, 2026
Merged

chore(openspec): cleanup p2-mad-core-t1 + add legacy-quality design.md#177
rubenvdlinde merged 1 commit into
developmentfrom
chore/decidesk-last-2-complete

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Contributor

Summary

Completes the last 2 OpenSpec changes still in the BLOCKED bucket for decidesk. Spec-only — no code changes.

p2-minutes-and-decisions-core-t1

  • Moved specs.md to the canonical OpenSpec path specs/p2-minutes-and-decisions-core-t1/spec.md, matching the directory convention used by sibling p2-* changes (motion-and-voting, agenda-management, meeting-management-*, minutes-and-decisions-other-t2).
  • Pure relocation via git mv — spec content unchanged (all 7 REQ groups: REQ-CDM, REQ-PPD, REQ-SDL, REQ-URG, REQ-ADL, REQ-ATR, REQ-ARC, plus REQ-NFR non-functional requirements).
  • Note: actual repo state had only specs.md (not both files as described in the brief). Moving to the canonical location is the equivalent cleanup — the canonical path now exists and the wrong-location file is gone.

decidesk-legacy-quality-cleanup

  • Added design.md (~560 words) covering:
    • Scope: PHPCS exclude-pattern burn-down (3 files), PHPMD baseline burn-down (51 lines), PHPStan first-run, CI wiring, documentation.
    • Execution order: 6 sequential phases so each PR re-baselines cleanly.
    • Relationship to quorum- migrations:* inverse scope — quality config vs. domain logic; non-overlapping file sets; safe to run in parallel; unified gate (Phase 5) catches any new sniff violations from quorum-* refactors.
    • Risk assessment: burn-down cascades, PHPStan first-run volume, unified-gate red flips, parallel quorum-* work.
    • Success criteria: zero phpcs excludes, deleted phpmd baseline, phpstan in check:strict, CI wiring, weekly cron, README + app-config.json updated.

Test plan

  • Confirm openspec/changes/p2-minutes-and-decisions-core-t1/specs/p2-minutes-and-decisions-core-t1/spec.md exists and matches the sibling p2-* directory layout.
  • Confirm openspec/changes/p2-minutes-and-decisions-core-t1/specs.md no longer exists.
  • Confirm openspec/changes/decidesk-legacy-quality-cleanup/design.md is present alongside proposal.md and tasks.md.
  • (Optional) Diff design.md against quorum-declarative-migration/design.md for stylistic consistency.

Notes

  • composer check:strict was skipped per the watchdog rules (spec-only change, no PHP touched).
  • Sibling p2-* changes also do not pass openspec validate (they use REQ-XXX-NNN headings instead of ## ADDED Requirements / #### Scenario: delta headers); this is a project-wide convention deviation, not introduced or aggravated by this PR.

p2-minutes-and-decisions-core-t1:
- Move specs.md to canonical openspec path specs/<cap>/spec.md
  (specs/p2-minutes-and-decisions-core-t1/spec.md) matching the
  convention used by sibling p2-* changes (motion-and-voting,
  agenda-management, meeting-management). Spec content is
  unchanged — pure relocation.

decidesk-legacy-quality-cleanup:
- Add design.md (~560 words) covering cleanup scope (phpcs excludes,
  phpmd baseline, phpstan first-run, CI wiring, docs), sequential
  execution order across 6 phases, relationship to the quorum-*
  declarative-migration series (inverse scope — no file overlap,
  safe to run in parallel), risk assessment, and success criteria.
@rubenvdlinde rubenvdlinde requested a review from Rem-Dam as a code owner May 11, 2026 08:07
@rubenvdlinde rubenvdlinde merged commit 3584934 into development May 11, 2026
13 of 14 checks passed
@rubenvdlinde rubenvdlinde deleted the chore/decidesk-last-2-complete branch May 11, 2026 08:08
@github-actions
Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidesk @ bcd3a05

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 100/100
npm ✅ 469/469
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-05-11 08:09 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant