chore(openspec): cleanup p2-mad-core-t1 + add legacy-quality design.md#177
Merged
Merged
Conversation
p2-minutes-and-decisions-core-t1: - Move specs.md to canonical openspec path specs/<cap>/spec.md (specs/p2-minutes-and-decisions-core-t1/spec.md) matching the convention used by sibling p2-* changes (motion-and-voting, agenda-management, meeting-management). Spec content is unchanged — pure relocation. decidesk-legacy-quality-cleanup: - Add design.md (~560 words) covering cleanup scope (phpcs excludes, phpmd baseline, phpstan first-run, CI wiring, docs), sequential execution order across 6 phases, relationship to the quorum-* declarative-migration series (inverse scope — no file overlap, safe to run in parallel), risk assessment, and success criteria.
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 469/469 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 08:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the last 2 OpenSpec changes still in the BLOCKED bucket for decidesk. Spec-only — no code changes.
p2-minutes-and-decisions-core-t1
specs.mdto the canonical OpenSpec pathspecs/p2-minutes-and-decisions-core-t1/spec.md, matching the directory convention used by sibling p2-* changes (motion-and-voting, agenda-management, meeting-management-*, minutes-and-decisions-other-t2).git mv— spec content unchanged (all 7 REQ groups: REQ-CDM, REQ-PPD, REQ-SDL, REQ-URG, REQ-ADL, REQ-ATR, REQ-ARC, plus REQ-NFR non-functional requirements).specs.md(not both files as described in the brief). Moving to the canonical location is the equivalent cleanup — the canonical path now exists and the wrong-location file is gone.decidesk-legacy-quality-cleanup
design.md(~560 words) covering:check:strict, CI wiring, weekly cron, README + app-config.json updated.Test plan
openspec/changes/p2-minutes-and-decisions-core-t1/specs/p2-minutes-and-decisions-core-t1/spec.mdexists and matches the sibling p2-* directory layout.openspec/changes/p2-minutes-and-decisions-core-t1/specs.mdno longer exists.openspec/changes/decidesk-legacy-quality-cleanup/design.mdis present alongsideproposal.mdandtasks.md.Notes
composer check:strictwas skipped per the watchdog rules (spec-only change, no PHP touched).openspec validate(they useREQ-XXX-NNNheadings instead of## ADDED Requirements/#### Scenario:delta headers); this is a project-wide convention deviation, not introduced or aggravated by this PR.