fix(settings): pass JSON data and version to OR ConfigurationService::importFromApp#199
Merged
rubenvdlinde merged 1 commit intoMay 13, 2026
Conversation
…:importFromApp The OpenRegister ConfigurationService::importFromApp signature changed from ($appId, $force) to ($appId, array $data, string $version, bool $force). The old 2-arg call was throwing ArgumentCountError at install/upgrade time, leaving 0/24 schemas configured and all Add-Item forms empty. This loads decidesk_register.json from lib/Settings/ in the app itself, extracts the version from info.version, and passes both to the 4-arg method (mirrors the working pattern in planix, scholiq, opencatalogi). Fixes #196
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 474/474 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-13 07:29 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
May 13, 2026
Re-captured all 52 tutorial screenshots against a dev container that now has decidesk's register configured (PR #199 fix) and a small seed-data set: - 1 governance body (Stadsraad Demoville) - 2 meetings (one past closed, one upcoming scheduled) - 2 motions (one adopted, one in debate) - 1 minutes record - 3 action items - 1 decision 48 of 52 PNGs are non-structural — they now show populated list views, real Add-Item dialogs with mapped schemas, and detail pages with content. The 4 unchanged ones are the AI-companion and a couple of flows that don't depend on register data. Spec used: tests/e2e/docs-screenshots.spec.ts (project: docs-capture).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OCA\OpenRegister\Service\ConfigurationService::importFromAppsignature changed from($appId, $force)to($appId, array $data, string $version, bool $force). Decidesk'sSettingsService::loadConfigurationwas still calling the old 2-arg signature with named args, which throwsArgumentCountErrorat install/upgrade time and on every settings reload.Net effect in the running dev container: register import fails →
0/24 configured→ empty Add-Item dropdowns → no usable seed data → tutorial-doc screenshots all show empty state.Fix
Mirror the working pattern from
planix,scholiq, andopencatalogi:lib/Settings/decidesk_register.jsonfrom diskinfo.version(appId, data, version, force)to the 4-arg methodOther Conduction apps affected by the same caller bug
shillinq(lib/Service/SettingsService.php:143) — tracking issue to followopenbuilt/lib/Resources/template/lib/Service/SettingsService.php:143— scaffold template, will propagate the bug to every freshly-generated appTest
After merge, will deploy in dev container, run
occ maintenance:repair, and verify decidesk reports a populated register via the OpenRegister API.Fixes #196