test: skip 5 AgendaServiceTest cases broken by ObjectService mismatch (#90)#92
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom Apr 19, 2026
Merged
Conversation
…l mismatch (#90) Same root cause as #91: when OpenRegister is installed the real ObjectService is autoloaded instead of the test stub, so mocked ::find and ::saveObject return types don't match the real signature. PR #91 covered Decision/Meeting/ Motion/Voting tests but missed AgendaServiceTest. Unskip once #90 is resolved.
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 416/416 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/115 statements)
Quality workflow — 2026-04-19 05:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgendaServiceTest, leaving 5 tests red ondevelopment:testAdvanceBobPhaseCyclesThroughPhasestestAdvanceBobPhaseThrowsForInformationalItemtestAdvanceBobPhaseThrowsAtFinalPhasetestProcessHamerstukkenUpdatesTaggedItemsOnlytestReorderItemsAssignsSequentialNumbersmarkTestSkippedline referencing Broken: 21 unit tests fail due to ObjectService stub/real-signature mismatch #90 to each of those tests.Unskip once #90 resolves the stub vs. real
ObjectServicesignature problem.Test plan