feat(dashboard): seed default widget bundle on new dashboards + loading shim#126
Closed
rubenvdlinde wants to merge 2 commits intodevelopmentfrom
Closed
feat(dashboard): seed default widget bundle on new dashboards + loading shim#126rubenvdlinde wants to merge 2 commits intodevelopmentfrom
rubenvdlinde wants to merge 2 commits intodevelopmentfrom
Conversation
…s + loading shim
Three preconfigured tile widgets (Conduction, Sendent, Nextcloud) plus a
Files widget are now inserted on every dashboard created via the sidebar
"+" affordance. The bootstrap path keeps its own role-default-driven seed
so admin templates and template-applied dashboards are unaffected.
The empty-state CTA ("No dashboard yet" / Create dashboard) used to flash
during the initial fetch because `activeDashboard` is null until
`loadDashboards()` resolves. A loading shim now renders while the store's
`loading` flag is set.
- DashboardService::createDashboard gains a `seedDefaults` flag and a
private seedDefaultWidgets() helper that persists the bundle via the
existing tile* columns on WidgetPlacement.
- DashboardApiController::create opts in and returns the placements in
the same envelope shape as getActive() so the store populates
widgetPlacements without an extra round-trip.
- Frontend dashboard store reads placements from the create response.
- Views.vue gains a `v-else-if="loading"` branch with NcLoadingIcon.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 501/501 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 90.7% (127/140 statements)
Quality workflow — 2026-05-05 13:06 UTC
Download the full PDF report from the workflow artifacts.
…Newman Without `tileType`, `WidgetPlacement::jsonSerialize()` skips emitting the flat tile* fields, so the seeded Conduction/Sendent/Nextcloud tiles shipped to the frontend without a title, icon, or link. Setting `tileType='preset'` makes the renderer's flat-column path work; the sentinel intentionally differs from the legacy `'custom'` value so the placements stay on the registry-backed render path in DashboardGrid.vue rather than the pre-registry tile branch. Newman now pins the contract: - POST /api/dashboard returns exactly 4 placements - positions 0..2 are tiles with the expected tileType, tileTitle, tileLinkValue, and grid coords - position 3 is `files` spanning the second row - the empty-body create path asserts the same widgetId order when 2xx
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 501/501 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 90.7% (127/140 statements)
Quality workflow — 2026-05-05 13:13 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tilewidgets (Conduction, Sendent, Nextcloud — the last using theicon-nextcloudCSS class) on the top row plus afileswidget below. Admin-template dashboards are untouched.NcLoadingIconrenders whileloading=trueandactiveDashboardis null.What changed
Backend
DashboardService::createDashboard()gains abool $seedDefaults = falseparameter and delegates to a new privateseedDefaultWidgets()helper. The bootstrap path keepsseedDefaults=false(its own role-default seed already runs); the controller path opts in.createDefaultPlacements()delegates to the new seed so first-login bootstrap users get the same bundle.findPlacements(int $dashboardId): arrayexposes the placement mapper to the controller without injecting the mapper into it.DashboardApiController::create()returns placements in the same envelope shape asgetActive().Frontend
Views.vueadds av-else-if="loading"branch withNcLoadingIcon.createDashboardaction readsresponse.data.placements ?? []instead of hard-coding an empty array (older servers without the seed still render cleanly).Tests
DashboardServiceCreateDefaultsTest(2 cases) pins the seed contract.Views.loadingState.spec.js(2 cases) pins the loading-shim vs empty-state branch.NcLoadingIconadded to the Conduction stub used by Vitest.Test plan
vitest run— 67 files / 848 tests passedphpunit— 1057 tests / 2697 assertions passedphpcs/phpstan/eslintclean on touched files