feat(in-app-docs): point in-app Documentation links at mydash.conduction.nl#133
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 6, 2026
Merged
Conversation
…ion.nl Companion to PR #132 which moved the Docusaurus deploy domain. The in-app `DOCS_URL` constant in `SidebarFooter.vue` and the `CnSettingsSection` `doc-url` in `AdminSettings.vue` still pointed at `https://mydash.app` — those are the targets of the sidebar footer's Documentation icon and the admin-page documentation link respectively, so users clicking either would have landed on the old domain. Updated both to `https://mydash.conduction.nl`. Test fixture in `SidebarFooter.spec.js` (which exact-asserts the URL) and the prose comments referencing the URL updated in lockstep so the spec still passes and the comments don't drift. No behaviour change beyond the link target. 857 vitest pass.
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 501/501 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 90.7% (127/140 statements)
Quality workflow — 2026-05-06 08:22 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to PR #132 (which moved the Docusaurus deploy domain). The in-app
DOCS_URLconstant inSidebarFooter.vueand theCnSettingsSectiondoc-urlinAdminSettings.vuestill pointed athttps://mydash.app— those are the targets of the sidebar footer's Documentation icon and the admin-page documentation link respectively, so users clicking either would have landed on the old domain.Updated both to
https://mydash.conduction.nl. The test fixture inSidebarFooter.spec.js(which exact-asserts the URL) and the prose comments referencing the URL are updated in lockstep so the spec still passes and the comments don't drift.What changed
src/components/Workspace/SidebarFooter.vue—DOCS_URLconstant + comment blocksrc/components/admin/AdminSettings.vue—CnSettingsSectiondoc-urlpropsrc/components/Workspace/__tests__/SidebarFooter.spec.js— exact-asserted URL in the test + comment block3 files, 6 insertions, 5 deletions. No behaviour change beyond the link target.
Test plan
vitest run— 857 / 857 pass (was already 857 before; SidebarFooter spec exercises the new URL)mydash.conduction.nl