chore(deps): bump @conduction/nextcloud-vue to 0.1.0-beta.17 (clears all eslint Nc* errors)#97
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 1, 2026
Conversation
…se Nc imports Picks up the Nc* re-exports added by ncvue PR #102 (per ADR-004 line 17: "NEVER import from @nextcloud/vue directly — use @conduction/nextcloud-vue which re-exports all"). beta.17 is the first published version with `export * from '@nextcloud/vue'` in the barrel — verified locally. Eslint impact: - Before: 32 errors, all `Nc<X> not found in '@conduction/nextcloud-vue' import/named` from PR #71's swap (the swap was correct per ADR-004 but the barrel hadn't shipped the re-exports yet) - After: 0 errors, 24 pre-existing JSDoc warnings (the `@spec` tag is a project convention, not standard JSDoc — out of scope) Side fix in AdminSettings.vue: collapse the two `from '@conduction/nextcloud-vue'` import statements (CnSettingsSection + the Nc* group) into one. eslint's `import/no-duplicates` correctly flagged them; pure cosmetic merge, no behavioural change. Once this lands, the eslint check on the next dev → beta → main release will go green automatically.
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 498/498 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-01 17:23 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
…ta17 chore(deps): bump @conduction/nextcloud-vue to 0.1.0-beta.17 (clears all eslint Nc* errors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes the eslint feedback loop opened by hydra ADR-004:
PR #71 swapped every `@nextcloud/vue` import in mydash to `@conduction/nextcloud-vue` per the ADR. But the barrel never actually re-exported the Nc* components, only the Cn* ones — so 32 `import/named` errors landed on dev/beta/main. Today's nextcloud-vue PR #102 added `export * from '@nextcloud/vue'` to the barrel. The fix shipped in `@conduction/nextcloud-vue@0.1.0-beta.16` and `0.1.0-beta.17` (verified the dist contains the re-export —
tar -xzOf … nextcloud-vue.esm.js | head -3showsexport * from '@nextcloud/vue';).What changes
Lint impact
Test plan